Remove isVideoArticle prop from youtubeAtomFeatureCard #15307
Open
Remove isVideoArticle prop from youtubeAtomFeatureCard #15307
Conversation
…access to format in this component. This means we can decide if its a video article within the component and reduce prop drilling
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
added
fronts + curation
maintenance
domlander
approved these changes
Feb 5, 2026
Contributor
|
Nice improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove isVideoArticle prop from youtubeAtomFeatureCard as there is access to format in this component.
This means we can decide if its a video article within the component.
Why?
Reduce the number of props and the amount of prop drilling.
Screenshots
This is a no-op change.