Conversation
jamesmockett
force-pushed
the
jm/coming-soon-lineup
branch
from
4459f51 to
d1b1b53
Compare
jamesmockett
force-pushed
the
jm/coming-soon-lineup
branch
from
5d4cc0f to
099b756
Compare
jamesmockett
force-pushed
the
jm/coming-soon-lineup
branch
from
099b756 to
275ecad
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
marjisound
left a comment
marjisound
left a comment
There was a problem hiding this comment.
Looks good, but left the comments to understand when we need to show the coming soon section
| isSubstitute={true} | ||
| isHome={false} | ||
| /> | ||
| {matchStats ? ( |
There was a problem hiding this comment.
There are 2 points here:
1- there's a check in FootballMatchInfo component where it only renders the Lineups component when the lineups data is available. So we willprobably need to remove that check if we want to make matchStats prop optional, right?
2- The match info pages are avaiable several days before a match is happening, but I thought we only want to show the lineups coming soon section about an hour before the match starts, is that right?
There was a problem hiding this comment.
-
I'll have a look at the existing check in
FootballMatchInfoas I wasn't sure of the best way to determine if the lineup data is available. -
I believe lineups are available 75 mins before a match, but I'm not sure how long we want to show 'coming soon' for before that. Showing it for several days before a match might be stretching the idea of 'coming soon'? This probably needs some more design / product input as I don't think we came to a definitive conclusion when we discussed it yesterday.
There was a problem hiding this comment.
Rather than making matchStats optional we could move the showLineups logic from FootballMatchInfo to here
jamesmockett
force-pushed
the
jm/coming-soon-lineup
branch
from
275ecad to
89a9b42
Compare
2 participants
What does this change?
Adds coming soon state to
LineupscomponentWhy?
The match lineup is not available until just ahead of kickoff time so we either need to hide the lineup entirely or show a placeholder
Screenshots