Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3c14be4
refactor(wip): designable banner v2 using compound pattern
Jan 15, 2026
687aeb8
refactor(designable-banner-v2): add close handling, tracking integrat…
Jan 16, 2026
6adfdf9
refactor(designable-banner-v2): improve mobile layout and conditional…
Jan 19, 2026
e168376
refactor(designable-banner-v2): replace context with prop drilling fo…
Jan 20, 2026
a14449f
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Jan 20, 2026
72eca7c
refactor(designable-banner-v2): rename index.ts to exports.ts and upd…
Jan 20, 2026
77a3e09
Merge branch 'jm/feat-refactor-banner-component' of github.com:guardi…
Jan 20, 2026
41a8819
refactor(designable-banner-v2): add explicit return type to getCompon…
Jan 20, 2026
11cbd67
refactor(designable-banner-v2): extract banner model logic into custo…
Jan 21, 2026
aa6e117
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Jan 21, 2026
0607ad0
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Jan 21, 2026
c8d446b
refactor: remove unused children prop from CloseableBannerProps inter…
Jan 27, 2026
5c60503
refactor: remove legacy designable banner import path
Jan 27, 2026
01fae3a
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Jan 27, 2026
0b8bdb2
Merge branch 'main' of github.com:guardian/dotcom-rendering into jm/f…
Feb 9, 2026
0574d4c
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Feb 9, 2026
543fc35
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Feb 13, 2026
70b1835
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Feb 18, 2026
fd2f019
refactor: deduplicate DesignableBanner stories
Feb 18, 2026
0970529
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Feb 25, 2026
99282b1
feat: remove banner-version query parameter handling from ReaderReven…
Feb 25, 2026
d9d899a
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Feb 25, 2026
e1fb34a
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Feb 27, 2026
6ee4f04
fix: simplify force-banner parameter detection in StickyBottomBanner
Mar 2, 2026
9cf210c
Merge branch 'jm/feat-refactor-banner-component' of github.com:guardi…
Mar 2, 2026
1d74018
Merge branch 'main' into jm/feat-refactor-banner-component
juabara Mar 2, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,8 @@ export const ReaderRevenueBanner = ({
(name === 'SignInPromptBanner'
? /* webpackChunkName: "sign-in-prompt-banner" */
import(`../marketing/banners/signInPrompt/SignInPromptBanner`)
: /* webpackChunkName: "designable-banner" */
import(`../marketing/banners/designableBanner/DesignableBanner`)
: /* webpackChunkName: "designable-banner-v2" */
import(`../marketing/banners/designableBanner/v2/Banner`)
)
.then((bannerModule: { [key: string]: React.ElementType }) => {
setBanner(() => bannerModule[name] ?? null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ const withBannerData =
onNotNowClick,
onCollapseClick,
onExpandClick,
bannerChannel,
content: {
mainContent: renderedContent,
mobileContent: renderedMobileContent ?? renderedContent,
Expand Down Expand Up @@ -358,7 +359,7 @@ const withBannerData =
);
}
} catch (err) {
console.log(err);
console.error(err);
}

return <></>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type { ReminderFields } from '@guardian/support-dotcom-components/dist/sh
import type {
ArticleCounts,
ArticleCountType,
BannerChannel,
ConfigurableDesign,
SelectedAmountsVariant,
SeparateArticleCount,
Expand Down Expand Up @@ -65,6 +66,7 @@ export interface BannerRenderProps {
onSignInClick?: () => void;
onCollapseClick: () => void;
onExpandClick: () => void;
bannerChannel: BannerChannel;
reminderTracking: ContributionsReminderTracking;
content: BannerTextContent;
countryCode?: string;
Expand All @@ -78,7 +80,7 @@ export interface BannerRenderProps {
choiceCardAmounts?: SelectedAmountsVariant;
choiceCardsSettings?: ChoiceCardsSettings;
tracking: Tracking;
submitComponentEvent?: (componentEvent: ComponentEvent) => void;
submitComponentEvent?: (componentEvent: ComponentEvent) => Promise<void>;
design?: ConfigurableDesign;
promoCodes?: string[];
isCollapsible?: boolean;
Expand Down
Loading
Loading