Conversation
There was a problem hiding this comment.
Pull request overview
This PR merges and consolidates the prior “corotational” BPM bond work (PR #8) into bond_style bpm/rotational, adding new runtime options for rotational reference frame and damping construction, plus updated documentation and a new example input.
Changes:
- Extend
bpm/rotationalwith selectableframe(average vs particle) anddamping(derivative vs dem) modes and update restart I/O accordingly. - Remove the separate
bpm/corotationalbond style implementation files. - Add a new BPM wire example and update the
bond_style bpm/rotationaldocumentation to describe the new keywords and theory.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/BPM/bond_bpm_rotational.h |
Updates the rotational bond style interface to support new frame/damping modes and revised history variables. |
src/BPM/bond_bpm_rotational.cpp |
Implements average-frame formulation + derivative damping, adds on-the-fly bond history initialization, and updates coeff/settings/restart handling. |
src/BPM/bond_bpm_corotational.h |
Removes the separate corotational bond style interface. |
src/BPM/bond_bpm_corotational.cpp |
Removes the separate corotational bond style implementation. |
examples/bpm/wires/in.bpm.wires |
Adds an example input demonstrating thin/coiled wire behavior with bpm/rotational. |
doc/src/bond_bpm_rotational.rst |
Documents new frame/damping keywords, updates equations/notation, and adds a new reference. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Few more clean ups here from copilot: jtclemm@99e974c I think that covers everything it said that was correct. Not sure how to add to this PR, but can just create another PR later. |
Thanks, I fetched it from your repo. I also gave you access to mine. |
This closes PR #8.