feat: implement on-chain accept for recurring agreements#1175
Open
Maikol wants to merge 5 commits intofeat/dips-pending-rca-consumerfrom
Open
feat: implement on-chain accept for recurring agreements#1175Maikol wants to merge 5 commits intofeat/dips-pending-rca-consumerfrom
Maikol wants to merge 5 commits intofeat/dips-pending-rca-consumerfrom
Conversation
Maikol
force-pushed
the
feat/dips-pending-rca-consumer
branch
from
63c1d69 to
1e56892
Compare
Maikol
force-pushed
the
feat/dips-on-chain-accept
branch
from
2a2152b to
d61927f
Compare
When generating allocation IDs for new DIP allocations, closed/stopped allocations still exist on-chain. The uniqueAllocationID function only knows about active allocations, so it can generate the same ID as a previously closed allocation. Add a retry loop that queries on-chain state and excludes colliding IDs before retrying.
Rewarded subgraphs use defaultAllocationAmount (or per-deployment rule), denied subgraphs use dipsAllocationAmount (default changed to 0 for altruistic allocations immune to force-close).
Add a filtered query method to PendingRcaConsumer so cleanupDipsRule doesn't re-fetch all proposals. Hoist duplicated createMockAllocation to top level in tests.
MoonBoi9001
changed the title
Maikol
force-pushed
the
feat/dips-on-chain-accept
branch
from
6905ed0 to
8ec9fd9
Compare
MoonBoi9001
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.