feat(hypergraph): use native spaceId/spaceIds/typeIds filters for entities query #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ities query The gaia API (geobrowser/gaia#293) added efficient native filters for the entities query: spaceId, spaceIds, typeId, and typeIds. These use indexed EXISTS subqueries instead of the previous approach which ran 2 subqueries per row causing O(n) overhead. This change updates findManyPublic to use the new native filters: - spaceId/spaceIds as top-level query arguments instead of inside filter - typeIds as a top-level argument instead of relation-based filtering The entitiesOrderedByProperty query still uses the old approach since it doesn't yet support the native typeIds filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
findManyPublicto use the new nativespaceId,spaceIds, andtypeIdsfilters added in geobrowser/gaia#293entitiesOrderedByPropertyquery still uses the old approach since it doesn't yet support nativetypeIdsfilterChanges
For the regular
entitiesquery:spaceId: $spaceIdas a top-level argument (single space)spaceIds: {in: $spaceIds}as a top-level argument (multi-space)typeIds: {in: $typeIds}as a top-level argument (replaces relation-based filter)