Skip to content

fix: set config version only if migrations ran #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackw merged 5 commits into from
Mar 6, 2026
+10 −1
Merged

fix: set config version only if migrations ran #2513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b79fda1
fix(create-plugin): only set root config version and commit if migrat…
jackw Mar 5, 2026
5b961eb
feat(create-plugin): if no migrations run don't show success message,…
jackw Mar 5, 2026
c5890ca
feat(create-plugin): await setConfig and add test
jackw Mar 5, 2026
fdaff0c
Update packages/create-plugin/src/codemods/migrations/manager.test.ts
jackw Mar 5, 2026
b271512
refactor(create-plugin): move check for migrations to run to update c…
jackw Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-plugin/src/codemods/migrations/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export async function runMigrations(migrations: Migration[], options: RunMigrati
}
}

setRootConfig({ version: CURRENT_APP_VERSION });
await setRootConfig({ version: CURRENT_APP_VERSION });

if (options.commitEachMigration) {
await gitCommitNoVerify(`chore: update .config/.cprc.json to version ${CURRENT_APP_VERSION}.`);
Expand Down
9 changes: 9 additions & 0 deletions packages/create-plugin/src/commands/update.command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@ export const update = async (argv: minimist.ParsedArgs) => {
}

const migrations = getMigrationsToRun(version, CURRENT_APP_VERSION);

if (migrations.length === 0) {
output.log({
title: 'No migrations to run, exiting.',
});

process.exit(0);
}

// filter out minimist internal properties (_ and $0) before passing to codemod
const { _, $0, ...codemodOptions } = argv;
await runMigrations(migrations, {
Expand Down
Loading