Skip to content

chore: test Gemini Code Assist #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kikoso wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: test Gemini Code Assist #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions maps-compose/src/main/java/com/google/maps/android/compose/TestGeminiReview.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package com.google.maps.android.compose

import androidx.compose.runtime.Composable
import com.google.android.gms.maps.GoogleMap

/**
* A test composable to trigger Gemini code assist reviews.
*/
@Composable
fun myBadComponent(map: GoogleMap?, text: String?) {
// Violation 1: myBadComponent is camelCase instead of PascalCase
// Violation 2: Missing modifier: Modifier = Modifier as first optional parameter
// Violation 3: raw GoogleMap object parameter instead of maps-compose components

// Violation 4: Forced unwrapping (!!)
val length = text!!.length

map?.uiSettings?.isZoomControlsEnabled = true
}
Loading