Open
Conversation
Collaborator
dkhawk
commented
Mar 10, 2026
dkhawk
commented
- Replaced hardcoded markers with dynamic parsing from monsters.json
- Implemented automated sequential tour of all markers in Kotlin and Java
- Added a long-press PopupMenu to the Random Monster button for quick selection
- Configured individual AltitudeModes for markers via JSON
- Replaced hardcoded markers with dynamic parsing from monsters.json - Implemented automated sequential tour of all markers in Kotlin and Java - Added a long-press PopupMenu to the Random Monster button for quick selection - Configured individual AltitudeModes for markers via JSON
dkhawk
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Maps3DSamples/ApiDemos/common/src/main/res/layout/activity_common_map.xml
Fixed
Show fixed
Hide fixed
Maps3DSamples/ApiDemos/common/src/main/res/layout/activity_common_map.xml
Fixed
Show fixed
Hide fixed
Maps3DSamples/ApiDemos/common/src/main/res/layout/activity_common_map.xml
Fixed
Show fixed
Hide fixed
dkhawk
force-pushed
the
feat/monster-tour
branch
from
a7fe7bd to
0297b97
Compare
… suite - Extracted JSON parsing logic into dedicated `Monster` and `MonsterParser` classes for both Kotlin and Java apps to clean up activity bloat. - Refactored `MarkersActivity` in both languages to utilize the new abstractions. - Fixed a timing bug in the Java `MarkersActivity` by ensuring `setMapMode` and marker placements await `setOnMapReadyListener`, aligning its behavior with the Kotlin implementation. - Added comprehensive unit tests for the parsing logic. - Added Robolectric integration tests to validate complex asset parsing in an emulated environment. - Migrated all test assertions to Google Truth (`com.google.truth:truth`) for better readability. - Added necessary test dependencies (Robolectric, Truth, JSON) to the relevant Version Catalogs.
…cellation - Implement double-wait pattern utilizing OnMapSteadyListener to prevent tour animations from skipping past unrendered terrain. - Added stopMonsterTour calls to all other navigation buttons.
| android:insetBottom="0dp" | ||
| android:insetTop="0dp" | ||
| android:alpha="0.4" | ||
| android:text="🗺️" |
Check warning
Code scanning / Android Lint
Hardcoded text Warning
| android:insetBottom="0dp" | ||
| android:insetTop="0dp" | ||
| android:alpha="0.4" | ||
| android:text="🎲" |
Check warning
Code scanning / Android Lint
Hardcoded text Warning
| android:alpha="0.4" | ||
| android:text="🎲" | ||
| android:textSize="20sp" | ||
| android:contentDescription="Fly to Random Monster" |
Check warning
Code scanning / Android Lint
Hardcoded text Warning
| android:layout_height="wrap_content" | ||
| android:layout_marginEnd="8dp" | ||
| app:icon="@drawable/public_24px" | ||
| android:contentDescription="Fly to Berlin" |
Check warning
Code scanning / Android Lint
Hardcoded text Warning
| android:layout_height="wrap_content" | ||
| android:layout_marginEnd="8dp" | ||
| app:icon="@drawable/location_city_24px" | ||
| android:contentDescription="Fly to NYC" |
Check warning
Code scanning / Android Lint
Hardcoded text Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.