feat: Overhaul Fly-Along with Nav Waypoints and Supersonic Pacing#28
Open
feat: Overhaul Fly-Along with Nav Waypoints and Supersonic Pacing#28
Conversation
dkhawk
force-pushed
the
feat/route-sample
branch
from
45573fb to
ce0e688
Compare
kikoso
reviewed
Mar 6, 2026
| @@ -0,0 +1,104 @@ | |||
| // Copyright 2025 Google LLC | |||
Collaborator
There was a problem hiding this comment.
We don't have the header check in this repo, but being a new file, it could be worth adding the 2026 year.
kikoso
reviewed
Mar 6, 2026
| @@ -0,0 +1,80 @@ | |||
| // Copyright 2025 Google LLC | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| // Copyright 2025 Google LLC | |
| // Copyright 2026 Google LLC |
kikoso
reviewed
Mar 6, 2026
| @@ -0,0 +1,104 @@ | |||
| // Copyright 2025 Google LLC | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| // Copyright 2025 Google LLC | |
| // Copyright 2026 Google LLC |
kikoso
reviewed
Mar 6, 2026
| @@ -0,0 +1,335 @@ | |||
| // Copyright 2025 Google LLC | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| // Copyright 2025 Google LLC | |
| // Copyright 2026 Google LLC |
kikoso
reviewed
Mar 6, 2026
| }) | ||
| }, | ||
| onRelease = { view -> | ||
| // Optional cleanup |
Collaborator
There was a problem hiding this comment.
Do we need any release method on the map? (more of an open question)
kikoso
reviewed
Mar 6, 2026
Collaborator
kikoso
left a comment
kikoso
left a comment
There was a problem hiding this comment.
LGTM! Left a couple of minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR overhauls the cinematic Fly-Along feature for the Route Demo.
Key Changes
RouteSteplocations from the Routes API.Verification
./gradlew :Maps3DSamples:advanced:app:compileDebugKotlin