fix(gax-internal): keep traces as Unset on success#4967
Merged
coryan merged 2 commits intogoogleapis:mainfrom Mar 10, 2026
Merged
fix(gax-internal): keep traces as Unset on success#4967coryan merged 2 commits intogoogleapis:mainfrom
Unset on success#4967coryan merged 2 commits intogoogleapis:mainfrom
Conversation
The convention / rules for OpenTelemetry are to keep traces as `Unset` on success.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4967 +/- ##
==========================================
- Coverage 93.94% 93.94% -0.01%
==========================================
Files 221 221
Lines 8538 8536 -2
==========================================
- Hits 8021 8019 -2
Misses 517 517 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westarle
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convention / rules for OpenTelemetry are to keep traces as
Unseton success.Fixes #4938. See that bug for background and justification, because we all think it is not intuitive.