Skip to content

fix(gax-internal): keep traces as Unset on success#4967

Merged
coryan merged 2 commits intogoogleapis:mainfrom
coryan:cleanup-gax-internal-otel-status-defaults-to-unset
Mar 10, 2026
Merged

fix(gax-internal): keep traces as Unset on success#4967
coryan merged 2 commits intogoogleapis:mainfrom
coryan:cleanup-gax-internal-otel-status-defaults-to-unset

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Mar 10, 2026

The convention / rules for OpenTelemetry are to keep traces as Unset on success.

Fixes #4938. See that bug for background and justification, because we all think it is not intuitive.

The convention / rules for OpenTelemetry are to keep traces as `Unset`
on success.
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.94%. Comparing base (15d5fce) to head (6daec9c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...c/gax-internal/src/observability/client_tracing.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4967      +/-   ##
==========================================
- Coverage   93.94%   93.94%   -0.01%     
==========================================
  Files         221      221              
  Lines        8538     8536       -2     
==========================================
- Hits         8021     8019       -2     
  Misses        517      517              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review March 10, 2026 13:50
@coryan coryan requested a review from a team as a code owner March 10, 2026 13:50
@coryan coryan enabled auto-merge (squash) March 10, 2026 14:19
@coryan coryan merged commit 14e27fa into googleapis:main Mar 10, 2026
35 checks passed
@coryan coryan deleted the cleanup-gax-internal-otel-status-defaults-to-unset branch March 10, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the span status as UNSET even on success

2 participants