chore: update googleapis and regenerate#17211
Merged
suztomo merged 1 commit intoMay 20, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces significant updates across several libraries, including the addition of GlobalVmExtensionPolicies and RolloutPlans to the Compute package, and AssessmentTask support to BigQuery Migration. Feedback identifies a bug in the Compute REST transport where logging.log is called without a required log level and recommends replacing broad, silent exception blocks with specific error logging to improve debuggability and prevent masking issues.
| .. code-block:: python | ||
| class MyCustomGlobalVmExtensionPoliciesInterceptor(GlobalVmExtensionPoliciesRestInterceptor): | ||
| def pre_aggregated_list(self, request, metadata): | ||
| logging.log(f"Received request: {request}") |
Contributor
There was a problem hiding this comment.
The logging.log function requires a log level as its first argument (e.g., logging.INFO). Using it with only a message string will result in a TypeError. Consider using logging.info or providing a level.
Suggested change
| logging.log(f"Received request: {request}") | |
| logging.info(f"Received request: {request}") |
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = type(request).to_json(request) | ||
| except: |
Contributor
There was a problem hiding this comment.
Avoid broad exception blocks that silently return None. Instead, catch Exception and log the error (e.g., using logging.warning) to aid in debugging and prevent masking underlying issues.
except Exception as e:
logging.warning(f"Unexpected error: {e}")References
- Avoid broad
except Exception:blocks that silently returnNone. Instead, log the exception (e.g., usinglogger.warning) to aid in debugging and prevent masking underlying issues.
Member
Author
|
"unit test / unit (3.13)" failed. Searching for "error", I found these log messages: |
Member
Author
|
Interestingly retry succeeded in "unit test / unit (3.13)". |
ohmayr
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update googleapis to the latest commit and regenerate all client libraries.