Skip to content

chore: bump gapic-generator to v1.32.0 for legacylibrarian#17188

Open
ohmayr wants to merge 1 commit into
mainfrom
bump-gapic-generator-to-v1.32
Open

chore: bump gapic-generator to v1.32.0 for legacylibrarian#17188
ohmayr wants to merge 1 commit into
mainfrom
bump-gapic-generator-to-v1.32

Conversation

@ohmayr
Copy link
Copy Markdown
Contributor

@ohmayr ohmayr commented May 19, 2026

bump gapic-generator to v1.32.0 for legacylibrarian

@ohmayr ohmayr requested a review from a team as a code owner May 19, 2026 20:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gapic-generator dependency version from 1.30.13 to 1.32.0 in .generator/requirements.in. A review comment identifies a potential mismatch between the package name gapic-generator and the intended package gapic-generator-python, suggesting an update to ensure the name aligns with the provided repository URL and PyPI package.

@@ -1,5 +1,5 @@
click
gapic-generator==1.30.13 # https://github.com/googleapis/gapic-generator-python/releases/tag/v1.30.13
gapic-generator==1.32.0 # https://github.com/googleapis/gapic-generator-python/releases/tag/v1.32.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The package name gapic-generator appears to be a mismatch with the repository URL provided in the comment (gapic-generator-python). The version 1.32.0 corresponds to the gapic-generator-python package on PyPI, while gapic-generator is a different, legacy package. Consider updating the package name to match the intended Python package and its repository.

gapic-generator-python==1.32.0 # https://github.com/googleapis/gapic-generator-python/releases/tag/v1.32.0

suztomo
suztomo previously approved these changes May 19, 2026
@suztomo
Copy link
Copy Markdown
Member

suztomo commented May 19, 2026

I tried this commit but it failed with the same error.

go run github.com/googleapis/librarian/tool/cmd/builddockerimages@latest --language python --version=${V}
docker run -u $(id -u):$(id -g) -v .:/repo -v ~/.cache:/.cache -w /repo docker.io/library/librarian-python:${V}  generate -v --all

@suztomo suztomo dismissed their stale review May 19, 2026 21:27

It still fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants