chore: bump gapic-generator to v1.32.0 for legacylibrarian#17188
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the gapic-generator dependency version from 1.30.13 to 1.32.0 in .generator/requirements.in. A review comment identifies a potential mismatch between the package name gapic-generator and the intended package gapic-generator-python, suggesting an update to ensure the name aligns with the provided repository URL and PyPI package.
| @@ -1,5 +1,5 @@ | |||
| click | |||
| gapic-generator==1.30.13 # https://github.com/googleapis/gapic-generator-python/releases/tag/v1.30.13 | |||
| gapic-generator==1.32.0 # https://github.com/googleapis/gapic-generator-python/releases/tag/v1.32.0 | |||
There was a problem hiding this comment.
The package name gapic-generator appears to be a mismatch with the repository URL provided in the comment (gapic-generator-python). The version 1.32.0 corresponds to the gapic-generator-python package on PyPI, while gapic-generator is a different, legacy package. Consider updating the package name to match the intended Python package and its repository.
gapic-generator-python==1.32.0 # https://github.com/googleapis/gapic-generator-python/releases/tag/v1.32.0
|
I tried this commit but it failed with the same error. |
bump gapic-generator to v1.32.0 for legacylibrarian