Skip to content

fix: Rename the 'seed' argument for setting an initial regional access boundary for clarity#17186

Merged
macastelaz merged 1 commit into
mainfrom
RenameRabSeed
May 19, 2026
Merged

fix: Rename the 'seed' argument for setting an initial regional access boundary for clarity#17186
macastelaz merged 1 commit into
mainfrom
RenameRabSeed

Conversation

@macastelaz
Copy link
Copy Markdown
Contributor

@macastelaz macastelaz commented May 19, 2026

No description provided.

@macastelaz macastelaz requested review from a team as code owners May 19, 2026 19:16
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the RSA cryptography implementation by making the 'rsa' library a core dependency and simplifying the 'RSASigner' and 'RSAVerifier' classes into aliases. It also updates regional access boundary parameter names, handles optional 'es' dependencies with try-except blocks, and simplifies test configurations. Feedback identifies several critical issues, including a breaking change caused by renaming the 'seed' parameter in 'credentials.py', a loss of polymorphic key handling in the RSA refactor, and a syntax error in 'setup.py' due to a missing unpacking operator. Other suggestions include restoring 'posargs' in the 'noxfile.py' to maintain developer experience and fixing various docstring typos and type-hinting issues.

Comment thread packages/google-auth/google/auth/credentials.py
Comment thread packages/google-auth/google/auth/crypt/rsa.py Outdated
Comment thread packages/google-auth/setup.py Outdated
Comment thread packages/google-auth/google/auth/crypt/__init__.py Outdated
Comment thread packages/google-auth/google/auth/crypt/es.py Outdated
Comment thread packages/google-auth/google/auth/crypt/es.py Outdated
Comment thread packages/google-auth/google/auth/crypt/rsa.py Outdated
Comment thread packages/google-auth/noxfile.py
@macastelaz macastelaz marked this pull request as draft May 19, 2026 19:29
@macastelaz macastelaz marked this pull request as ready for review May 19, 2026 20:19
@macastelaz macastelaz merged commit e5c8cf9 into main May 19, 2026
31 checks passed
@macastelaz macastelaz deleted the RenameRabSeed branch May 19, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nbayati nbayati nbayati approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nbayati nbayati

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macastelaz @nbayati