Skip to content

chore(ci): remove legacy generate test#17170

Draft
noahdietz wants to merge 2 commits into
googleapis:mainfrom
noahdietz:remove-legacy-generate-test
Draft

chore(ci): remove legacy generate test#17170
noahdietz wants to merge 2 commits into
googleapis:mainfrom
noahdietz:remove-legacy-generate-test

Conversation

@noahdietz
Copy link
Copy Markdown
Contributor

Removes the legacylibrarian Python container test for generate, which is no longer maintained or used.

The image build step is retained for build verification triggered by changes to the .generator/ directory. Unit tests otherwise cover the code therein.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the CI process by removing the library generation and building steps from cloudbuild-test.yaml, leaving only the generator image build verification. Additionally, two JSON metadata files for google-cloud-language were deleted. The reviewer suggests optimizing the build resources by reducing the timeout and machine type, and using the --no-push flag for Kaniko to avoid potential tag collisions during pull request builds.

Comment thread cloudbuild-test.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant