feat: regenerate google-cloud-datacatalog-lineage#17148
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
This was skipped in #16997 - I'm not sure why, but that was with the previous generator. If it all looks okay now, we should unskip. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the SearchLineageStreaming method to the Data Catalog Lineage service, along with supporting types like DependencyInfo and LineageLink. It also implements automatic request_id population for several methods and updates Python version support to version 3.10 or higher. The review feedback highlights a misleading docstring for the streaming return type, suggests avoiding bare except: blocks in favor of except Exception: with logging, and notes that removing the -W flag from the documentation build is a regression in quality control.
| be of type `bytes`. | ||
|
|
||
| Returns: | ||
| ~.lineage.SearchLineageStreamingResponse: |
There was a problem hiding this comment.
The docstring for the return value of __call__ in _SearchLineageStreaming is misleading. Since this is a streaming method, it returns a rest_streaming.ResponseIterator which yields multiple response objects, not a single SearchLineageStreamingResponse instance.
| ~.lineage.SearchLineageStreamingResponse: | |
| Iterable[~.lineage.SearchLineageStreamingResponse]: |
| try: | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
| request_payload = None |
There was a problem hiding this comment.
Avoid using bare except: blocks. Catching Exception is preferred to avoid intercepting system-level signals. Additionally, ensure the exception is logged (e.g., using logger.warning) rather than silently handled to aid in debugging and prevent masking underlying issues.
| request_payload = None | |
| except Exception: |
References
- Avoid broad except Exception: blocks that silently return None. Instead, log the exception (e.g., using logger.warning) to aid in debugging and prevent masking underlying issues.
| shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | ||
| session.run( | ||
| "sphinx-build", | ||
| "-W", # warnings as errors |
There was a problem hiding this comment.
The removal of the -W flag from sphinx-build is a regression in documentation quality control. This flag ensures that documentation warnings are treated as errors. Furthermore, changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
References
- Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
2 participants
No description provided.