feat: func to generate V7 from custom time#175
Open
lazybark wants to merge 4 commits intogoogle:masterfrom
Open
feat: func to generate V7 from custom time#175lazybark wants to merge 4 commits intogoogle:masterfrom
lazybark wants to merge 4 commits intogoogle:masterfrom
Conversation
Introduce NewV7FromTime to provide more flexible use
bormanp
approved these changes
Nov 14, 2024
bormanp
suggested changes
Nov 14, 2024
rockwotj
reviewed
Jan 29, 2025
| defer timeMu.Unlock() | ||
|
|
||
| nano := timeNow().UnixNano() | ||
| nano := t.UnixNano() |
There was a problem hiding this comment.
Due to the behavior later in this function with lastV7time I don't think we want that when using a custom timestamp. Basically if you pass in a future time, then a past time, the past time will get reset to be in the future. I opened #182 that doesn't have this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces NewV7FromTime to provide more flexible use