Fix bug in updating registrar display name canonicalization#2957
Merged
CydeWeys merged 1 commit intogoogle:masterfrom Feb 13, 2026
Merged
Fix bug in updating registrar display name canonicalization#2957CydeWeys merged 1 commit intogoogle:masterfrom
CydeWeys merged 1 commit intogoogle:masterfrom
Conversation
We have a restriction in our system that registrar display names be unique (as the display name is how registrars are queried through RDAP). And, the uniqueness constraint is enforced on the canonicalized version of the display name (with spaces and non alphanumeric characters removed). However, in the check enforcing this uniqueness, we were incorrectly checking against the existing saved entity of the same registrar, meaning that you couldn't update the display name of a single registrar to a new value that canonicalized the same (you would instead have to rename it to something else first that doesn't canonicalize the same, and then afterwards to the new desired value). That didn't make sense, so now we exclude the existing registrar entity from consideration when checking if there are conflicts.
njshah301
approved these changes
Feb 13, 2026
Collaborator
njshah301
left a comment
njshah301
left a comment
There was a problem hiding this comment.
@njshah301 made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a restriction in our system that registrar display names be unique (as the display name is how registrars are queried through RDAP). And, the uniqueness constraint is enforced on the canonicalized version of the display name (with spaces and non alphanumeric characters removed). However, in the check enforcing this uniqueness, we were incorrectly checking against the existing saved entity of the same registrar, meaning that you couldn't update the display name of a single registrar to a new value that canonicalized the same (you would instead have to rename it to something else first that doesn't canonicalize the same, and then afterwards to the new desired value).
That didn't make sense, so now we exclude the existing registrar entity from consideration when checking if there are conflicts.
This change is