Set heap size flags in nomulus start script#2956
Conversation
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jicelhay).
jetty/start.sh line 31 at r1 (raw file):
esac java $PROFILER_ARGS \ -XX:InitialRAMPercentage=50.0 \
Add a comment here explaining the reasoning behind 50%? (In particular, how we only run 1 Java instance per container, or whatever the exact finding was.)
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jicelhay).
jicelhay
left a comment
There was a problem hiding this comment.
@jicelhay resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @CydeWeys).
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jicelhay).
With these changes we are explicitly setting heap sizes in relation to container's memory limit.
Max heap was defaulting to 25%, which isn't optimal for our settings (one-ish app per container).
b/468369756
This change is