Dont include CTest if HWY_ENABLE_TESTS is off. #2837
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I've now signed the CLA for my account. That check can be re-run. |
Member
|
Thanks for making the change! I think the CLA check is still failing because the email address is x*@noreply.git.xo.codes, but the check requires that this match the CLA email. Can we change that? |
Introduces [the change proposed](google#2833 (comment)) by jan-wassenberg This change avoids including CTest or creating unused testing targets when HWY_ENABLE_TESTS is off. Fixes google#2833
Author
|
Alright, the CLA should be sorted now. Had to re-author the commit with a real email unfortunately, but c'est la vie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the change proposed by jan-wassenberg
This change avoids including CTest or creating unused testing targets when HWY_ENABLE_TESTS is off.
Fixes #2833
Testing done:
cmake -B my_build -S . -G "Visual Studio 17 2022"cmake -B my_build -S . -DHWY_ENABLE_TESTS=OFF -G "Visual Studio 17 2022"