Add Windows (clang-cl) support for continuous fuzzing#1994
Open
posidron wants to merge 1 commit intogoogle:mainfrom
Open
Add Windows (clang-cl) support for continuous fuzzing#1994posidron wants to merge 1 commit intogoogle:mainfrom
posidron wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
df0304d to
976dcec
Compare
976dcec to
b983b49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable continuous fuzzing (
--fuzz=) on Windows with clang-cl.Problem
FuzzTest's continuous fuzzing mode fails on Windows with:
Despite clang-cl correctly applying
-fsanitize-coverage=inline-8bit-countersand the__sanitizer_cov_8bit_counters_initcallback firing, the coverage data is never used becauseFUZZTEST_COVERAGE_IS_AVAILABLEexcludes_WIN32.CorpusCoverage::Update()compiles as a stub returningfalseon Windows, so the fuzzer never considers any input as providing new coverage.Changes
Add
defined(_WIN32)to theFUZZTEST_COVERAGE_IS_AVAILABLEguard - clang-cl supports the same sanitizer coverage instrumentation as clang on Linux/macOS.Use
_aligned_malloc/_aligned_freeon Windows — the MSVC CRT does not providestd::aligned_alloc. Memory allocated with_aligned_mallocmust be freed with_aligned_free(notstd::free).