Add a minimal catalog for use with experimental renderers#732
Add a minimal catalog for use with experimental renderers#732gspencergoog merged 3 commits intogoogle:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a minimal A2UI component catalog, which is a great idea for lowering the barrier to entry for testing new renderers. The changes include the JSON schema for the minimal catalog, a set of example JSON files demonstrating its use, and a README file for documentation. The implementation looks solid and well-structured. My feedback is minor and relates to a consistent formatting issue across the newly added JSON files.
| ] | ||
| } | ||
| } | ||
| ] No newline at end of file |
There was a problem hiding this comment.
It's a standard convention to end files with a newline character. Some tools and systems expect this and may not process the file correctly without it. I've noticed this in all the new JSON files in this pull request.
| ] | |
| ] | |
| ] | ||
| } | ||
| } | ||
| ] No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file. It's a standard convention that helps prevent issues with some file processing tools.
| ] | |
| ] | |
| ] | ||
| } | ||
| } | ||
| ] No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file. It's a standard convention that helps prevent issues with some file processing tools.
| ] | |
| ] | |
| ] | ||
| } | ||
| } | ||
| ] No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file. It's a standard convention that helps prevent issues with some file processing tools.
| ] | |
| ] | |
| ] | ||
| } | ||
| } | ||
| ] No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file. It's a standard convention that helps prevent issues with some file processing tools.
| ] | |
| ] | |
| ] | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Please add a newline at the end of the file. It's a standard convention that helps prevent issues with some file processing tools.
| } | |
| } | |
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
This seems like a good idea to have. It will add some maintenance burden to keep up to date, but I like the idea.
2 participants
This is intended to lower the bar for testing a renderer. You can just implement the minimal catalog and then run a test app against it, rather than building out all the catalog items in the basic catalog.