Add explicit change detection to all Angular components#726
Open
crisbeto wants to merge 1 commit intogoogle:mainfrom
Open
Add explicit change detection to all Angular components#726crisbeto wants to merge 1 commit intogoogle:mainfrom
crisbeto wants to merge 1 commit intogoogle:mainfrom
Conversation
crisbeto
requested review from
ava-cassiopeia,
ditman,
dmandar,
gspencergoog,
jacobsimionato,
nan-yu and
zeroasterisk
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates Angular dependencies and explicitly sets the change detection strategy to Eager for all components to prepare for a future change in Angular's default strategy. The changes are extensive and have been applied consistently across the codebase. I've found one inconsistency in the updated dependency versions in package.json that should be addressed. I've also included a suggestion to consider using OnPush change detection for simpler components, which could be a performance improvement and a step towards the long-term goal of adopting OnPush.
We're in the process of changing Angular's default change detection from `Eager` to `OnPush`. These changes update all existing A2UI code to explicitly set `Eager` so that it doesn't break when the default is flipped. I've also updated to the latest stable version of Angular.
crisbeto
force-pushed
the
change-detection-eager
branch
from
9f2f9ce to
2cd6ef5
Compare
ava-cassiopeia
approved these changes
Feb 26, 2026
Collaborator
ava-cassiopeia
left a comment
ava-cassiopeia
left a comment
There was a problem hiding this comment.
LGTM, thanks for converting these over!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're in the process of changing Angular's default change detection from
EagertoOnPush. These changes update all existing A2UI code to explicitly setEagerso that it doesn't break when the default is flipped. I've also updated to the latest stable version of Angular.