-
Notifications
You must be signed in to change notification settings - Fork 872
Remove overflow: hidden from border-radius utility classes #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
selamw1
wants to merge
1
commit into
google:main
Choose a base branch
from
selamw1:fix/lit-renderer-text-clipping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import test from 'node:test'; | ||
| import assert from 'node:assert'; | ||
| import { border } from './border.js'; | ||
|
|
||
| test('Border Styles', async (t) => { | ||
| await t.test('border-radius classes should not apply overflow: hidden to avoid text clipping', () => { | ||
| // The issue reported clipping of text when using rounded corners because | ||
| // .border-br-* generated classes also blindly applied overflow: hidden. | ||
|
|
||
| // Check if the generated CSS contains overflow: hidden for border-br classes | ||
| const match = border.match(/\.border-br-\w+ \{[^}]*overflow:\s*hidden/); | ||
| assert.strictEqual(match, null, 'Found overflow: hidden applied within a border-br-* class'); | ||
|
|
||
| // Check that we DO have the expected border-radius applied | ||
| const hasBorderRadius = border.match(/\.border-br-1 \{ border-radius: [^;]+; \}/); | ||
| assert.notStrictEqual(hasBorderRadius, null, 'Missing border-radius in border-br-* class'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ export const border = ` | |
| .border-brw-${idx} { border-right-width: ${idx}px; } | ||
|
|
||
| .border-ow-${idx} { outline-width: ${idx}px; } | ||
| .border-br-${idx} { border-radius: ${idx * grid}px; overflow: hidden;}`; | ||
| .border-br-${idx} { border-radius: ${idx * grid}px; }`; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Per the repository style guide, code changes should include tests. To prevent this text clipping issue from recurring, please consider adding a test case (e.g., a visual regression test) that verifies this fix. References
|
||
| }) | ||
| .join("\n")} | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll be adding screenshot tests to more robustly test this in some future changes, but in the meantime, can you add this new
testcommand to .github/workflows/web_build_and_test.yml so that these get executed automatically?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test command added.