Remove notion of "custom catalogs" from agent SDK#705
Open
nan-yu wants to merge 1 commit intogoogle:mainfrom
Open
Remove notion of "custom catalogs" from agent SDK#705nan-yu wants to merge 1 commit intogoogle:mainfrom
nan-yu wants to merge 1 commit intogoogle:mainfrom
Conversation
nan-yu
requested review from
ava-cassiopeia,
crisbeto,
ditman,
dmandar,
gspencergoog,
jacobsimionato,
paullewis and
zeroasterisk
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This is a substantial but well-executed refactoring that removes the concept of "custom catalogs" needing runtime resolution, in favor of pre-bundled, self-contained catalogs. The changes centralize schema and validation logic, simplify the A2uiSchemaManager API, and improve the overall architecture. The test suite has been commendably updated to cover the new structure. I have one suggestion for a minor performance optimization.
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
nan-yu
force-pushed
the
remove-custom-notion
branch
2 times, most recently
from
aaf183d to
27bb573
Compare
gspencergoog
approved these changes
Feb 24, 2026
Collaborator
|
/gemini summary |
Contributor
Summary of ChangesThis pull request significantly refactors the A2UI SDK's approach to managing UI component catalogs. By eliminating the distinction of 'custom catalogs' and introducing a unified Highlights
Changelog
|
nan-yu
force-pushed
the
remove-custom-notion
branch
from
27bb573 to
7c31917
Compare
nan-yu
force-pushed
the
remove-custom-notion
branch
from
7c31917 to
09f576f
Compare
The basic catalog maintained by the A2UI team has no difference from third-party catalogs. This PR removes the notion of custom catalogs. Each catalog provided at runtime should be independent and immutable. At build time, catalogs can refer to components from other catalogs. They need to be bundled into a free-standing one using the `tools/build_catalog/build_catalog.py` script. Fixes google#650
nan-yu
force-pushed
the
remove-custom-notion
branch
from
09f576f to
268c25f
Compare
This comment was marked as spam.
This comment was marked as spam.
jacobsimionato
requested changes
Feb 25, 2026
Collaborator
There was a problem hiding this comment.
Thanks for fixing this!!
| """Returns a CatalogConfig for the basic catalog.""" | ||
| return cls( | ||
| name=BASIC_CATALOG_NAME, | ||
| catalog_path="", # basic catalog doesn't need a path from the user |
Collaborator
There was a problem hiding this comment.
Why doesn't this need a path? Otherwise, the core code won't know where to load it from, right?
Collaborator
Author
There was a problem hiding this comment.
The basic catalog and other core schemas (server-to-client and common types) are bundled directly within the SDK. pack_specs_hook.py packs the specs into the package assets. The SDK then loads them as package resources. We only require a path when a user is loading a custom catalog from their own filesystem.
| examples_path: Optional[str] = None | ||
|
|
||
| @classmethod | ||
| def for_basic_catalog(cls, examples_path: Optional[str] = None) -> "CatalogConfig": |
Collaborator
There was a problem hiding this comment.
Can we move this to a top-level function in a different file, perhaps even a different folder, e.g. inference/basic_catalog or something?
That makes the conceptual separation clear, and avoids us accidentally sprinkling basic catalog assumptions into the core library. Ideally, it would be possible for us to publish basic catalog support as a completely separate library which depends on the core inference library.
Collaborator
There was a problem hiding this comment.
+1 on this, then we can run the basic catalog through the sdk like any other catalog
| ) | ||
| if not basic_catalog_schema: | ||
| basic_catalog_schema = {} | ||
| basic_catalog_schema = _load_basic_component(version, CATALOG_SCHEMA_KEY) |
Collaborator
There was a problem hiding this comment.
Ideally, avoid having this special cased logic. I wonder if we can publish the basic catalog schema as a JSON file bundled with the library?
Or perhaps the parameter of CatalogConfig could actually just be a "CatalogProvider" which could either be a FileReadingCatalogProvider which reads a JSON file on disk, or just an InlineCatalogProvider which returns a catalog baked into Python code as a string constant (so it's easy for us to create for the basic catalog).
wrenj
reviewed
Feb 25, 2026
| return cls( | ||
| name=BASIC_CATALOG_NAME, | ||
| catalog_path="", # basic catalog doesn't need a path from the user | ||
| examples_path=examples_path, |
Collaborator
There was a problem hiding this comment.
maybe just examples_paths=
versus doing an ls of a directory? what if there .git file in that directory?
| """Determines the catalog to use based on supported catalog IDs. | ||
|
|
||
| If neither inline catalogs nor supported catalog IDs are provided, the basic catalog is used. | ||
| If neither inline catalogs nor client-supported catalog IDs are provided, the first agent-supported catalog is used. |
Collaborator
There was a problem hiding this comment.
is it first in the client_capabitilities or first in the supported_catalogs?
| self._schema_manager = ( | ||
| A2uiSchemaManager("0.8", basic_examples_path="examples") if use_ui else None | ||
| A2uiSchemaManager( | ||
| "0.8", |
Collaborator
There was a problem hiding this comment.
maybe make some consts here?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The basic catalog maintained by the A2UI team has no difference from third-party catalogs.
This PR removes the notion of custom catalogs. Each catalog provided at runtime should be independent and immutable. At build time, catalogs can refer to components from other catalogs. They need to be bundled into a
free-standing one using the
tools/build_catalog/build_catalog.pyscript.Fixes: #650
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.