Fix conversion of datetimes in TransferData#1372
Merged
sirosen merged 1 commit intoglobus:mainfrom Feb 27, 2026
Merged
Conversation
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
requested changes
Feb 27, 2026
The `deadline` field accepts a datetime but does not stringify it. On `DeleteData`, the same field exists, with the same semantics, and is passed to our internal `stringify()` helper. Apply the same here as the fix so that the two remain consistent. A new unit test verifies the results. Note that this calls `str(deadline)`, which *does not* produce an ISO 8601 date string. This was the behavior in the 3.x versions of the SDK as well, which is part of why it is being kept rather than fixed at this time. Fixing it will require evaluating what the Transfer APIs accept. Fixes globus#1371
sirosen
force-pushed
the
bugfix-datetime-conversions
branch
from
1b3016e to
cef0d21
Compare
kurtmckee
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deadlinefield accepts a datetime but does not stringify it.On
DeleteData, the same field exists, with the same semantics, and ispassed to our internal
stringify()helper. Apply the same here as thefix so that the two remain consistent.
A new unit test verifies the results.
Note that this calls
str(deadline), which does not produce anISO 8601 date string. This was the behavior in the 3.x versions of the
SDK as well, which is part of why it is being kept rather than fixed at
this time.
Fixing it will require evaluating what the Transfer APIs accept.
Fixes #1371