Fix action failure when pull request is closed without merging #179
+32
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action was failing when processing pull requests that were closed without merging, throwing a "Cannot iterate over null" error during the content metadata parsing step.
Root Cause
When a pull request is closed without merging, the GitHub GraphQL API returns
nullfor the node in the query response. ThefetchContentMetadatafunction was attempting to accessresult.node.projectItems.nodeswithout first checking ifresult.nodewas null, causing the action to crash.Solution
Added a null check for
result.nodein thefetchContentMetadatafunction. When the node is null, the action now:Additional Fix
Also resolved an unrelated bug in the
convertValueToFieldTypefunction where it was checking forfieldType === "NUMBER"instead offieldType === "number", causing number field conversions to fail.Testing
Before this fix, users would see:
After this fix, users will see a clear error message:
Fixes #12.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.