fix(yaml): add parameter definitions for goose recipe validation

[zichen0116]

Summary

• Add parameters field to generated YAML recipe files when {{args}} placeholder is used
• Goose recipe validation requires that all template variables have corresponding parameter definitions

Problem

When running goose recipe validate on spec-kit generated recipe files, validation fails with:

Error: recipe file is invalid: Missing definitions for parameters in the recipe file: args.

This happens because the generated YAML recipes use {{args}} in the prompt body but don't define the args parameter in the recipe header.

Fix

• Modified _render_yaml() to accept an optional parameters argument and include it in the YAML header
• Updated setup() to detect {{args}} in the prompt body and pass the corresponding parameter definition

Testing

• Existing YAML integration tests continue to pass
• Generated recipes now include the parameters field when {{args}} is used

Fixes #2423

[Copilot]

Pull request overview

This PR aims to fix Goose recipe validation by teaching the YAML recipe generator to emit parameter metadata for the {{args}} placeholder used in spec-kit command templates. It fits into the integration layer that materializes agent-specific command files from the shared template set.

Changes:

• Extended YamlIntegration._render_yaml() to optionally include a parameters header section.
• Updated YamlIntegration.setup() to detect {{args}} in generated recipe bodies and inject an args parameter definition.
• Kept the rest of the Goose YAML recipe structure unchanged.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mnriem]

Please address Copilot feedback. If not applicable, please explain why

[zichen0116]

Thanks for the review! I've addressed both issues:

1. render_yaml_command fix: Updated CommandRegistrar.render_yaml_command() in agents.py to detect {{args}} in the body and pass parameters to _render_yaml(). This covers the preset/extension registration path.

2. Regression test: Added test_yaml_has_parameters_when_args_placeholder to verify that generated YAML recipes include the parameters block when {{args}} is used.

The body already has {{args}} by the time render_yaml_command is called (line 491-493 in agents.py converts $ARGUMENTS to the agent's args placeholder before the format-specific renderer is invoked).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (3)

src/specify_cli/agents.py:268

• This call to _render_yaml(...) is on a single long line and is likely to violate the repo’s Ruff default line-length rule (E501). Please wrap the call across multiple lines (or assign to a local variable) to keep lines within the configured limit.

        return YamlIntegration._render_yaml(title, description, body, source_id, parameters=params)

src/specify_cli/agents.py:262

• There’s no test coverage for the new behavior here (adding parameters when the args placeholder is present). The integration tests cover YamlIntegration.setup(), but this code path is used when rendering YAML via CommandRegistrar (e.g., extension/preset overrides), so a focused unit test should be added to prevent regressions.

        params = None
        if "{{args}}" in body:
            params = [
                {
                    "key": "args",

src/specify_cli/integrations/base.py:1301

• setup() uses arg_placeholder when processing templates, but the parameter injection check is hard-coded to "{{args}}". To avoid drift if the configured args placeholder changes, key this check off arg_placeholder (or a shared helper) instead of a literal string.

            params = None
            if "{{args}}" in body:
                params = [

• Files reviewed: 3/3 changed files
• Comments generated: 2

[mnriem]

Please address Copiot feedback