Add safe-outputs configuration to notion-issue-summary workflow#13844
Closed
Add safe-outputs configuration to notion-issue-summary workflow#13844
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix safe-outputs configuration in notion-issue-summary workflow
Add safe-outputs configuration to notion-issue-summary workflow
Feb 5, 2026
Contributor
|
@copilot notion.md exposes a custom job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
notion-issue-summaryworkflow creates issue summary comments but was missing safe-outputs configuration, preventing it from using the structured safe-outputs pipeline. Audit identified this as 1 of 9 workflows without safe-outputs, though the other 8 legitimately don't need it (tests, examples, read-only operations).Changes
safe-outputs: add-comment: max: 1to.github/workflows/notion-issue-summary.mdfrontmatter.lock.ymlwith safe-outputs infrastructureThis enables the workflow's existing instruction to "use the
notion_add_commentsafe-job" to function correctly through the safe-outputs framework with proper validation and constraint enforcement.Increases safe-outputs coverage from 93.8% to 94.5% (137/145 workflows).
Original prompt
This section details on the original issue you should resolve
<issue_title>[q] Fix notion-issue-summary workflow safe-outputs configuration</issue_title>
<issue_description>## Summary
This PR addresses a finding from the Agentic Workflow Audit Report (Discussion github/gh-aw#13735) by adding safe-outputs configuration to the
notion-issue-summary.mdworkflow.Investigation Findings
The audit report identified 9 workflows without safe-outputs (6.2% of 145 workflows). After detailed investigation of each workflow, I found that:
notion-issue-summary.mdWorkflows Without Safe-Outputs - Analysis
chroma-issue-indexer.mdcodex-github-remote-mcp-test.mdexample-custom-error-patterns.mdexample-permissions-warning.mdfirewall.mdmetrics-collector.mdtest-workflow.mdtest-yaml-import.mdnotion-issue-summary.mdChanges Made
Modified File:
.github/workflows/notion-issue-summary.mdAdded safe-outputs configuration:
Rationale: This workflow analyzes issues and creates summaries as comments, but was missing the safe-outputs configuration needed to properly integrate with the safe-outputs framework. This fix ensures the workflow can create comments through the structured safe-outputs pipeline.
Other Audit Findings Investigated
Network Security ✅ Already Configured
Workflows using
web-fetchor external network access already have propernetwork: allowed:configuration with explicit domain allow-lists. No changes needed.Examples:
cli-version-checker.md:allowed: [defaults, node, "api.github.com", "ghcr.io"]cli-consistency-checker.md:allowed: [defaults, node, "api.github.com"]MCP Server Adoption ✅ Acceptable
Low MCP adoption (2.8% - only 4 workflows) is intentional and acceptable. Most workflows work perfectly with built-in tools. MCP servers add complexity and should only be used when specialized capabilities are needed.
Runtime Metrics⚠️ Cannot Fix in Workflows
The audit noted that runtime metrics are unavailable due to missing gh CLI authentication. This is an infrastructure/CI configuration issue, not something that can be fixed in workflow files.
Validation
✅ Changes compiled and validated locally
✅ Only modified the workflow that genuinely needed safe-outputs
✅ No unnecessary changes to working configurations
✅ Minimal, surgical fix addressing the actual issue
Expected Improvements
References
/q fixfrom @pelikhanThis is a targeted, minimal fix based on thorough investigation of the audit findings. Only 1 of the 9 workflows flagged actually needed safe-outputs - the other 8 are legitimately configured for their specific use cases (tests, examples, read-only operations).
To apply the patch locally:
Show patch (36 lines)