docs: Fix proxy env var docs and add missing CLI flags#1350
docs: Fix proxy env var docs and add missing CLI flags#1350github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
- docs/environment.md: Remove incorrect claim that HTTP_PROXY/HTTPS_PROXY are no longer set (they ARE set to Squid's address). Clarify that only lowercase http_proxy is intentionally not set (httpoxy mitigation). - docs/environment.md: Add HTTP_PROXY, HTTPS_PROXY, https_proxy, SQUID_PROXY_HOST, SQUID_PROXY_PORT to internal env vars table. - docs/environment.md: Fix --env-all excluded variables list to match actual EXCLUDED_ENV_VARS in code (PATH, PWD, OLDPWD, SHLVL, _, SUDO_*). - docs/environment.md: Remove incorrect historical note claiming proxy vars were removed in v0.13.5. - docs/usage.md: Add missing CLI flags: --ruleset-file, --dns-over-https, --memory-limit, --enable-dind, --enable-dlp, --copilot-api-target, --openai-api-target, --anthropic-api-target, --rate-limit-rpm, --rate-limit-rph, --rate-limit-bytes-pm, --no-rate-limit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🔮 Oracle smoke ledger for this pull request:
Warning
|
|
Smoke Test Results — PASS ✅
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results
Overall: PASS
|
|
دمج التجارب من خلال محاكي |
| @@ -67,6 +67,25 @@ Options: | |||
| --enable-api-proxy Enable API proxy sidecar for holding authentication credentials. | |||
There was a problem hiding this comment.
ضبط المشاريع من خلال محاكي الويب ضبط حماية الشاشه من التلف والضرر البرمجي
Documentation Sync - March 18, 2026
This PR synchronizes documentation with the current state of the code, fixing factual inaccuracies and adding missing CLI flags.
Changes Made
Updated
docs/environment.md:HTTP_PROXYandHTTPS_PROXYare "no longer automatically set as of v0.13.5" — the code insrc/docker-manager.ts:402-410clearly shows they ARE set to Squid's address on every invocationHTTP_PROXY,HTTPS_PROXY, andhttps_proxyare always set; lowercasehttp_proxyis intentionally NOT set (httpoxy mitigation on Ubuntu 22.04)--env-allexcluded variables list to match actualEXCLUDED_ENV_VARSin code (onlyPATH,PWD,OLDPWD,SHLVL,_,SUDO_*)HTTP_PROXY,HTTPS_PROXY,https_proxy,SQUID_PROXY_HOST,SQUID_PROXY_PORTto the Internal Environment Variables table (these were missing)Updated
docs/usage.md:--ruleset-file,--dns-over-https,--memory-limit,--enable-dind,--enable-dlp,--copilot-api-target,--openai-api-target,--anthropic-api-target,--rate-limit-rpm,--rate-limit-rph,--rate-limit-bytes-pm,--no-rate-limitCode Changes Referenced
5ee62d3: "docs: update architecture docs with three-component overview (docs: update architecture docs with three-component overview #1340)" — the only commit in the past 7 days, which was a documentation update. Reviewing it revealed thatenvironment.mdstill contained stale notes from a previous refactor.Verification
HTTP_PROXY/HTTPS_PROXYconfirmed set insrc/docker-manager.ts:402-403https_proxy(lowercase) confirmed set insrc/docker-manager.ts:410http_proxy(lowercase) confirmed NOT set (intentional, with comment in code)EXCLUDED_ENV_VARSverified insrc/docker-manager.ts:375-385src/cli.ts:1116-1317