Add Helm template validation for mutually exclusive namespace flags#65
Merged
bdehamer merged 2 commits intobdehamer/helmfrom Mar 20, 2026
Merged
Add Helm template validation for mutually exclusive namespace flags#65bdehamer merged 2 commits intobdehamer/helmfrom
bdehamer merged 2 commits intobdehamer/helmfrom
Conversation
Co-authored-by: bdehamer <398027+bdehamer@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/deployment-tracker/sessions/ab6214f1-4681-454f-b5de-7d0caa1a9cc9
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Helm chart for deployment-tracker implementation
Add Helm template validation for mutually exclusive namespace flags
Mar 20, 2026
bdehamer
approved these changes
Mar 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds Helm-side validation to prevent generating an invalid controller Deployment when both config.namespace and config.excludeNamespaces are set, matching the controller’s runtime constraint.
Changes:
- Add a Helm template
failguard to aborthelm install/upgradeifconfig.namespaceandconfig.excludeNamespacesare both non-empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.namespaceandconfig.excludeNamespacesare mutually exclusive — the controller callsos.Exit(1)when both are set — but the chart previously rendered both args without complaint, producing a broken install.Changes
templates/deployment.yaml: Adds afailguard at the top of the template that abortshelm install/helm upgradewith a clear error when both values are non-empty:💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.