-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rust: Handle Deref trait in type inference and data flow
#20987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hvitved
wants to merge
4
commits into
github:main
Choose a base branch
from
hvitved:rust/type-inference-deref-trait
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,817
−1,117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
265
to
297
| /** | ||
| * Index assignments like `a[i] = rhs` are treated as `*a.index_mut(i) = rhs`, | ||
| * so they should in principle be handled by `referenceAssignment`. | ||
| * | ||
| * However, this would require support for [generalized reverse flow][1], which | ||
| * is not yet implemented, so instead we simulate reverse flow where it would | ||
| * have applied via the model for `<_ as core::ops::index::IndexMut>::index_mut`. | ||
| * | ||
| * The same is the case for compound assignments like `a[i] += rhs`, which are | ||
| * treated as `(*a.index_mut(i)).add_assign(rhs)`. | ||
| * | ||
| * [1]: https://github.com/github/codeql/pull/18109 | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style Warning
The QLDoc for a predicate without a result should start with 'Holds'.
baba061 to
5dda9be
Compare
eb1db27 to
e269016
Compare
| pragma[nomagic] | ||
| Type getACandidateReceiverTypeAtSubstituteLookupTraits( | ||
| string derefChain, boolean borrow, TypePath path | ||
| Type getANonPseudoCandidateReceiverTypeAt( |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
The QLDoc has no documentation for borrow, or derefChain, or path, but the QLDoc mentions unknown
8266451 to
14037e4
Compare
14037e4 to
0c7b1d0
Compare
7880183 to
be3a16a
Compare
cc413c1 to
adcbfc8
Compare
dd62164 to
dc0c45b
Compare
f3bad27 to
c23d528
Compare
Deref trait in type inferenceDeref trait in type inference and data flow
c23d528 to
76ad749
Compare
76ad749 to
2927d7d
Compare
60d9084 to
de3a73e
Compare
5c70ae0 to
20ebba3
Compare
9190142 to
00b243a
Compare
00b243a to
a291add
Compare
a291add to
452da63
Compare
452da63 to
2d8da40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds general support for the
Dereftrait when resolving method calls, which means both supporting it when actually resolving method calls in the type inference library, but also inserting the implicitderefcalls in data flow.Type inference
When resolving method calls, a set of candidate receiver types are constructed by repeatedly dereferencing the receiver using applicable
Derefimplementations. Before this PR, we had limited support, namely&(mut) T -> TandString -> str. In order to handle arbitrary chains of dereferences, we introduce a new classDerefChain, based on the sharedUnboundListlibrary, which records the chain ofderefcalls needed to resolve a method call.After having resolved a method call, type information may also have to flow backwards through the chain of dereferences. Example:
Support for this is implemented in the
inferMethodCallTypeSelfpredicate, where theDerefChainis applied in reverse order, peeling off the top element until the chain becomes empty.Data flow
A method call
x.m()with an implicit dereference desugars to(*Deref::deref(&x)).m(), so we need to add data flow nodes for&x,Deref::deref(&x), and*Deref::deref(&x), as well as the implicit call toDeref::deref. This means we will have a reference store-step fromxto&xand a reference read-step fromDeref::deref(&x)to*Deref::deref(&x).The three different data flow nodes are represented by a state called
ImplicitDerefNodeState, and since we need to support arbitrary dereference chains, each synthetic node is additionally tagged with aDerefChainas well as an index into that chain.A small, but important, performance improvement is made when the targeted
derefmethod is one of the two built-in implementations; in this case, we can add a local flow step directly fromxtoDeref::deref(&x), which avoids the need for inter-procedural flow.