Merge releases/v4 into releases/v3#3826
Merged
henrymercer merged 82 commits intoreleases/v3from Apr 15, 2026
Merged
Conversation
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.12 to 1.1.13. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.12...v1.1.13) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
We originally moved these to `ubuntu-slim`, but there is a significant performance difference. Since we often find ourselves waiting on these jobs, let's use the faster runners.
…pansion-1.1.13 Bump brace-expansion from 1.1.12 to 1.1.13
…ency Remove unused `@schemastore/package` dependency
Mergeback v4.35.1 refs/heads/releases/v4 into main
Move time-sensitive Actions workflows to `ubuntu-latest`
For the sake of consistency with the other pre-existing validation code.
…-no-submodules Overlay: Only require Git 2.36.0 for repos that contain submodules
The registry/language mapping table does not map the one with hyphens.
Generate and analyse esbuild bundle metadata
henrymercer
added
Rebuild
Contributor
Author
|
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
henrymercer
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Mergeback from releases/v4 into releases/v3, bringing in release tooling updates, dependency bumps, and multiple behavior changes (proxy, overlay caching refactor, Swift handling, etc.).
Changes:
- Upgrade TypeScript/tooling and adjust build pipeline to emit and report esbuild bundle metadata.
- Refactor overlay database caching into dedicated modules and update imports/tests accordingly.
- Update start-proxy language alias handling and OIDC credential property names; add/adjust PR checks and workflows.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | TS compiler config updates for TS6 (moduleResolution/types/skipLibCheck/paths). |
| src/trap-caching.ts | Emit deprecation warning for TRAP cache cleanup. |
| src/tools-features.ts | Remove Python stdlib extraction tools feature flag reference. |
| src/testing-utils.ts | Update overlay mode import path. |
| src/status-report.ts | Update overlay caching stats import path. |
| src/start-proxy/types.ts | Switch OIDC config JSON property names to kebab-case; update validators/formatting. |
| src/start-proxy/types.test.ts | Update tests for new OIDC property names. |
| src/start-proxy.ts | Use checked-in language aliases JSON; update language parsing and OIDC config shaping. |
| src/start-proxy.test.ts | Add multi-registry tests; update OIDC property name fixtures. |
| src/overlay/overlay-database-mode.ts | New enum module for overlay database mode. |
| src/overlay/index.ts | Remove caching logic; retain overlay OID/changes-file logic. |
| src/overlay/index.test.ts | Remove caching tests from overlay index suite. |
| src/overlay/caching.ts | New module containing overlay-base DB cache upload/download/key logic. |
| src/overlay/caching.test.ts | New test suite for overlay cache behavior and key stability. |
| src/known-language-aliases.json | Add checked-in snapshot of language aliases. |
| src/init-action.ts | Update overlay imports; treat Swift on non-macOS as configuration error; remove Python stdlib override logic. |
| src/init-action-post-helper.ts | Update overlay mode import path. |
| src/init-action-post-helper.test.ts | Update overlay mode import path in tests. |
| src/git-utils.ts | Add submodule detection; only use --recurse-submodules when needed; rename min Git version constant. |
| src/git-utils.test.ts | Add coverage for submodule/no-submodule argument selection and updated stubbing. |
| src/feature-flags.ts | Remove Python stdlib extraction feature flag wiring. |
| src/defaults.json | Bump default CLI/bundle version to 2.25.2 (and prior versions accordingly). |
| src/database-upload.ts | Update overlay mode import path. |
| src/config-utils.ts | Only enforce Git ≥ 2.36.0 when repo has submodules; update overlay mode import. |
| src/config-utils.test.ts | Update overlay enablement tests for submodule-aware Git version checks. |
| src/codeql.ts | Update overlay mode import path. |
| src/cli-errors.ts | Add Swift incompatible-OS classification. |
| src/cli-errors.test.ts | Add test for Swift incompatible-OS classification. |
| src/analyze.ts | Update overlay mode import path. |
| src/analyze-action.ts | Import overlay cache upload from new module. |
| pr-checks/tsconfig.json | TS6-related config tweak (module: preserve). |
| pr-checks/sync-checks.ts | Extract API client construction into reusable module. |
| pr-checks/config.ts | Add path constant for esbuild metadata file. |
| pr-checks/checks/start-proxy.yml | Extend start-proxy PR check to validate multiple registries. |
| pr-checks/checks/rubocop-multi-language.yml | Update ruby/setup-ruby pin. |
| pr-checks/checks/language-aliases.yml | Remove Swift from language-aliases PR check expectations. |
| pr-checks/bundle-metadata.ts | New script to print esbuild bundle sizes from metafile. |
| pr-checks/api-client.ts | New shared Octokit client helper for PR checks scripts. |
| package.json | Bump action version; run bundle-metadata script as part of build; dependency/devDependency bumps. |
| package-lock.json | Lockfile updates for bumped dependencies/tooling and version fields. |
| build.mjs | Enable esbuild metafile output and write meta.json. |
| CHANGELOG.md | Add 3.35.2 release notes and date. |
| .gitignore | Ignore generated meta.json. |
| .github/workflows/update-release-branch.yml | Switch runner to ubuntu-latest; bump create-github-app-token. |
| .github/workflows/update-bundle.yml | Switch runner to ubuntu-latest; add step to update checked-in language aliases. |
| .github/workflows/rollback-release.yml | Bump create-github-app-token. |
| .github/workflows/prepare-release.yml | Switch runner to ubuntu-latest. |
| .github/workflows/post-release-mergeback.yml | Switch runner to ubuntu-latest; bump create-github-app-token. |
| .github/workflows/debug-artifacts-failure-safe.yml | Explicitly set languages list for init step. |
| .github/workflows/__start-proxy.yml | Generated workflow update mirroring start-proxy check changes. |
| .github/workflows/__rubocop-multi-language.yml | Generated workflow update mirroring rubocop check changes. |
| .github/workflows/__language-aliases.yml | Generated workflow update mirroring language-aliases check changes. |
| .github/dependabot.yml | Expand Dependabot config to cover additional directories. |
| lib/upload-sarif-action-post.js | Generated bundle output update (do not review source-of-truth). |
| lib/start-proxy-action-post.js | Generated bundle output update (do not review source-of-truth). |
| lib/defaults.json | Generated output update for defaults.json. |
Copilot's findings
- Files reviewed: 47/66 changed files
- Comments generated: 1
Comment on lines
7
to
9
| "_build_comment": "echo 'Run the full build so we typecheck the project and can reuse the transpiled files in npm test'", | ||
| "build": "./scripts/check-node-modules.sh && npm run transpile && node build.mjs", | ||
| "build": "./scripts/check-node-modules.sh && npm run transpile && node build.mjs && npx tsx ./pr-checks/bundle-metadata.ts", | ||
| "lint": "eslint --report-unused-disable-directives --max-warnings=0 .", |
There was a problem hiding this comment.
npm run build now executes npx tsx ..., but tsx is not listed in devDependencies. This makes builds depend on network availability and may pull different tsx versions over time. Add tsx as a pinned dev dependency (or vendor the script into an existing toolchain) to make builds reproducible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging 95e58e9 into
releases/v3.Conductor for this PR is @henrymercer.
Contains the following pull requests:
@schemastore/packagedependency #3779 (@henrymercer)ubuntu-latest#3786 (@henrymercer)pr-checks/tsconfig.jsonfor TS6 #3810 (@mbg)overlay/caching.ts#3819 (@henrymercer)Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.