Skip to content

Fix flaky mobile-safari e2e test: assert input value before click #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evcatalyst merged 2 commits into from
Mar 21, 2026
+9 −0
Merged

Fix flaky mobile-safari e2e test: assert input value before click #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2262cd
Initial plan
Copilot Mar 21, 2026
676bba0
Fix flaky mobile-safari e2e test: assert searchbox value after fill b…
Copilot Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pwa/e2e/journey.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('06 – Search "awful" navigates to result page', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await shot(page, '06-before-search-submit')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
Expand All @@ -137,6 +138,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('07 – Result page shows word title', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await expect(page.getByRole('heading', { name: 'awful' })).toBeVisible()
Expand All @@ -146,6 +148,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('08 – Result page shows summary banner', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await expect(page.getByTestId('summary-banner')).toBeVisible()
Expand All @@ -155,6 +158,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('09 – Result page shows Then/Now snapshots', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await expect(page.getByTestId('snapshot-now')).toBeVisible()
Expand All @@ -165,6 +169,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('10 – Navigate to Timeline from Result', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await page.getByTestId('view-timeline-btn').click()
Expand All @@ -176,6 +181,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('11 – Timeline scrubber shows eras', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await page.getByTestId('view-timeline-btn').click()
Expand All @@ -187,6 +193,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('12 – Navigate to Source Detail from Result', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await page.getByTestId('source-card').first().getByText('Details →').click()
Expand All @@ -198,6 +205,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('13 – "Ask BackWords" explain button appears', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await page.getByTestId('source-card').first().getByText('Details →').click()
Expand All @@ -209,6 +217,7 @@ test.describe('BackWords PWA — search flow with mock API', () => {
test('14 – Back navigation returns to result', async ({ page }) => {
await page.goto(`${BASE}/`)
await page.getByRole('searchbox').fill('awful')
await expect(page.getByRole('searchbox')).toHaveValue('awful')
await page.getByRole('button', { name: 'Search' }).click()
await page.waitForURL(`**${BASE}/result`, { waitUntil: 'commit' })
await page.getByRole('button', { name: 'Back to search' }).click()
Expand Down
Loading