feat: Sync attachments on Android, Windows, and Linux#2609
Merged
bitsandfoxes merged 5 commits intomainfrom Apr 2, 2026
Merged
feat: Sync attachments on Android, Windows, and Linux#2609bitsandfoxes merged 5 commits intomainfrom
bitsandfoxes merged 5 commits intomainfrom
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+168
to
+175
| [DllImport(SentryLib)] | ||
| internal static extern IntPtr sentry_attach_file(string path); | ||
|
|
||
| [DllImport(SentryLib)] | ||
| internal static extern IntPtr sentry_attach_bytes(byte[] buf, UIntPtr buf_len, string filename); | ||
|
|
||
| [DllImport(SentryLib)] | ||
| internal static extern void sentry_clear_attachments(); |
There was a problem hiding this comment.
Bug: The contentType for attachments is silently discarded in the native implementation for Windows/Linux, as the P/Invoke calls sentry_attach_file and sentry_attach_bytes do not pass this parameter.
Severity: MEDIUM
Suggested Fix
Investigate if the underlying sentry-native C API supports setting the content type. If it does, update the P/Invoke signatures and the NativeScopeObserver.cs implementation to pass the contentType to the native layer. If not, add logging to warn the user that contentType is being ignored on native platforms.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/Sentry.Unity.Native/CFunctions.cs#L168-L175
Potential issue: The abstract `AddAttachment` method and its implementations in
`ScopeObserver` correctly handle a `contentType` parameter. However, the native
implementation for Windows/Linux in `NativeScopeObserver.cs` calls P/Invoke functions
(`sentry_attach_file` and `sentry_attach_bytes`) that do not accept a `contentType`.
This causes the content type information to be silently lost for attachments on these
platforms, creating an inconsistency with the Android implementation which correctly
preserves it. This degrades functionality by stripping metadata from native attachments.
Did we get this right? 👍 / 👎 to inform future reviews.
mujacica
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on:
With this,
fileandbyteattachments get synced to the native layer on Android, Windows, and Linux and will be available on events originating from these layers.