Skip to content

fix(reqwest): do not pull in aws-lc-rs by default #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomaseizinger wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −205
Open

fix(reqwest): do not pull in aws-lc-rs by default #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
205 changes: 1 addition & 204 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sentry/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ curl = ["dep:curl", "httpdate"]
ureq = ["dep:ureq", "httpdate"]
# transport settings
native-tls = ["dep:native-tls", "reqwest?/native-tls", "ureq?/native-tls"]
rustls = ["dep:rustls", "reqwest?/rustls", "ureq?/rustls"]
rustls = ["dep:rustls", "reqwest?/rustls-no-provider", "ureq?/rustls"]
Copy link
Copy Markdown

@cursor cursor Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rustls feature breaks reqwest transport without crypto provider

High Severity

Changing reqwest?/rustls to reqwest?/rustls-no-provider means no crypto provider (ring or aws-lc-rs) is bundled for the reqwest transport. When a user enables rustls + reqwest features (the documented way to use rustls), rustls::ClientConfig::builder() will panic at runtime with "no process-level CryptoProvider available" because no compiled-in provider exists. The .expect() in reqwest.rs compounds this with a misleading message suggesting to "Enable either the native-tls or the rustls feature" even though rustls is already enabled. Meanwhile, ureq?/rustls (unchanged) still bundles ring, creating an inconsistency where ureq works but reqwest doesn't.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d0ea483. Configure here.

embedded-svc-http = ["dep:embedded-svc", "dep:esp-idf-svc"]

[dependencies]
Expand Down
Loading