fix(breakpad): pre-load psapi to prevent frequent loader deadlock#1502
Closed
fix(breakpad): pre-load psapi to prevent frequent loader deadlock#1502
Conversation
MiniDumpWriteDump calls LoadPsApi at runtime to enumerate modules. If this happens while the parallel DLL loader has pending work, it can deadlock in LdrpDrainWorkQueue. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
f1c31f3 to
87e3c58
Compare
6044e10 to
e59f32a
Compare
Collaborator
Author
|
Another deadlock occurred in the same test with this workaround applied... [2964] Main thread
[6120] ntdll TppWorkerThread 2 threads |
Collaborator
Author
|
Not convinced this helps much. Pre-loading psapi.dll only helps with the specific deadlock that was easiest to reproduce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1501
Summary
Fixes a deadlock that occurred when capturing crash dumps on Windows while network requests were in flight. See #1501 for detailed stack traces and investigation.
Problem
When a crash occurs, Breakpad calls
MiniDumpWriteDumpwhich internally loadspsapi.dllat runtime for module enumeration. If another thread (e.g., WinHTTP worker) has pending work in the parallel DLL loader, this deadlocks inLdrpDrainWorkQueue.Solution
Pre-load
psapi.dllduring Breakpad backend startup, ensuring it's already loaded before any crash handling occurs.Test plan