feat(user-reports): Migrate standalone logic#5731
Open
tobias-wilfert wants to merge 3 commits intomasterfrom
Open
feat(user-reports): Migrate standalone logic#5731tobias-wilfert wants to merge 3 commits intomasterfrom
tobias-wilfert wants to merge 3 commits intomasterfrom
Conversation
tobias-wilfert
commented
Mar 16, 2026
Comment on lines
+107
to
+108
| /// A list of reports. | ||
| reports: Vec<Item>, |
Member
Author
There was a problem hiding this comment.
This is a Vec rather than Items because the processing logic calls fn process_user_reports(user_reports: &mut Vec<Item>, records: &mut RecordKeeper<'_>) which is shared with the error processor (don't think we want to change it to use Items).
There might be a more elegant/better approach here.
tobias-wilfert
commented
Mar 16, 2026
Comment on lines
+8
to
+13
| /// Validates and normalizes all user report items in the envelope. | ||
| /// | ||
| /// User feedback items are removed from the envelope if they contain invalid JSON or if the | ||
| /// JSON violates the schema (basic type validation). Otherwise, their normalized representation | ||
| /// is written back into the item. | ||
| pub fn process_user_reports(user_reports: &mut Vec<Item>, records: &mut RecordKeeper<'_>) { |
Member
Author
There was a problem hiding this comment.
Logic moved from the error processor.
tobias-wilfert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the standalone user report logic out of
process_standalone, migrating the logic to the new processor architecture.Ref: https://linear.app/getsentry/issue/INGEST-817/extract-user-report-logic-from-process-standalone