Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: sqlite3 context manager doesn't close the connection
- Replaced
with sqlite3.connect(...)with an explicit connection andfinally: conn.close()so the SQLite handle is always closed before temporary directory cleanup.
- Replaced
Or push these changes by commenting:
@cursor push 9668ec0f9f
Preview (9668ec0f9f)
diff --git a/tests/integration/test_basic.py b/tests/integration/test_basic.py
--- a/tests/integration/test_basic.py
+++ b/tests/integration/test_basic.py
@@ -85,10 +85,13 @@
assert mini_sentry.captured_envelopes.empty()
# Check if there's data in the SQLite table `envelopes`.
- with sqlite3.connect(db_file_path) as conn:
+ conn = sqlite3.connect(db_file_path)
+ try:
cursor = conn.cursor()
cursor.execute("SELECT COALESCE(SUM(count), 0) FROM envelopes")
row_count = cursor.fetchone()[0]
+ finally:
+ conn.close()
assert (
row_count == nThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
jjbayer
approved these changes
Mar 16, 2026
Ensure the sqlite handle is explicitly closed after reading the spool table.
…raceful_shutdown_with_sqlite_buffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Trying to improve and fix the flaky test.
The CI job logs have expired.
However I can reproduce some flakiness locally so I’ve fixed that part I saw in the reproductions.
fix: RELAY-176