feat(#312): adds support for the masked appearance#655
Conversation
🦋 Changeset detectedLatest commit: 5fe6db0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
latin-panda
left a comment
latin-panda
left a comment
There was a problem hiding this comment.
I have one small question below, but I am approving now to unblock
| :model-value="node.currentState.value" | ||
| :feedback="false" | ||
| fluid | ||
| toggleMask |
There was a problem hiding this comment.
| toggleMask | |
| toggle-mask |
It has this warning from GH
There was a problem hiding this comment.
Yikes, thanks!
I've modified the eslint config so this is now an error not a warning so it's easier to spot. Are you ok with that upgrade?
| <Password | ||
| :id="node.nodeId" | ||
| :required="node.currentState.required" | ||
| :disabled="node.currentState.readonly" |
There was a problem hiding this comment.
When the input is disabled, I can still reveal the secret word. Is that okay?
Screen.Recording.2026-02-17.at.8.58.17.PM.mov
There was a problem hiding this comment.
I think it's ok because my understanding of the purpose of this feature is to hide the content from shoulder surfers, not from the user. If you really don't want the user to see it then you shouldn't display it in the form at all (ie: make the field not relevant).
2 participants
Closes #312
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
The all questions form works.
What's changed