Skip to content

chore: switch merge-schedule to reminder workflow#51

Merged
ajbozarth merged 1 commit into
generative-computing:mainfrom
ajbozarth:chore/merge-schedule-reminder
May 21, 2026
Merged

chore: switch merge-schedule to reminder workflow#51
ajbozarth merged 1 commit into
generative-computing:mainfrom
ajbozarth:chore/merge-schedule-reminder

Conversation

@ajbozarth
Copy link
Copy Markdown
Contributor

Summary

Switch the scheduled-merge workflow from auto-enqueueing PRs to posting a reminder comment, and update author docs to match.

The old behavior fails silently with merge queue enabled: the workflow successfully calls gh pr merge --auto, but because the actor is github-actions[bot], the resulting merge_group event is suppressed by GitHub's "GITHUB_TOKEN can't trigger workflows" rule. CI never runs on the queued ref and the queue evicts the PR after ~1 hour. Confirmed against PR #36 — enqueued by the workflow at 15:12, evicted at 16:15 with zero CI runs in between, then manually re-enqueued by a human and merged in 13s once merge_group actually fired.

The reminder-only model has the bot identify due PRs and ping the author/assignees; a human does the enqueue gesture so merge_group fires correctly.

Changes

  • Bump pin in .github/workflows/merge-schedule.yml to generative-computing/.github@d04be31 (the new reminder-only reusable workflow).
  • Drop contents: write permission from the caller (no longer merging anything).
  • Rename caller workflow (Scheduled MergeScheduled Merge Reminder) and job (merge-scheduled-prsremind-scheduled-prs) to match the upstream rename.
  • Update CONTRIBUTING.md and AGENTS.md to:
    • Recommend /remind YYYY-MM-DD (the new keyword; legacy /schedule still works upstream) at PR open, matching the front matter date.
    • Document that the front matter date should be future-dated to reflect when the post goes live, not when it was drafted.
    • Describe the new reminder behavior — the workflow no longer auto-enqueues, it just nudges.

Test plan

  • Confirm the workflow file parses and the workflow_dispatch trigger is wired.
  • Manual smoke test: trigger via workflow_dispatch with a test PR carrying a past-dated /remind, verify a reminder comment appears mentioning the author.
  • Verify a future-dated /remind is skipped on the same run.
  • Verify a second workflow_dispatch run on the same PR posts a fresh reminder (daily nudges, no idempotency suppression).

@ajbozarth ajbozarth requested a review from a team as a code owner May 21, 2026 19:25
@ajbozarth ajbozarth requested review from psschwei and serjikibm May 21, 2026 19:25
@ajbozarth ajbozarth self-assigned this May 21, 2026
The scheduled-merge workflow can no longer auto-enqueue PRs once merge
queue is enabled — actions taken by GITHUB_TOKEN don't fire merge_group
events, so CI never runs on the queued ref and the queue evicts the PR.

Bump the workflow pin to the new reminder-only version, drop the
contents:write permission, and update CONTRIBUTING/AGENTS to describe
the new behavior. Also recommend setting /remind YYYY-MM-DD at PR open
matching the front matter date, and document that the date should be
future-dated to reflect when the post will go live.

Assisted-by: Claude Code
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth force-pushed the chore/merge-schedule-reminder branch from 687a4f6 to e61b256 Compare May 21, 2026 19:28
@ajbozarth ajbozarth added this pull request to the merge queue May 21, 2026
@psschwei
Copy link
Copy Markdown
Member

Just want to confirm, this wasn't a required check (and thus doesn't need to be updated in the branch protections) right?

@ajbozarth
Copy link
Copy Markdown
Contributor Author

Just want to confirm, this wasn't a required check (and thus doesn't need to be updated in the branch protections) right?

No, its just a cron, and even if it wasn't this removed the perms it did use to "write" now it just posts comments

Merged via the queue into generative-computing:main with commit 307b88e May 21, 2026
6 checks passed
@ajbozarth ajbozarth deleted the chore/merge-schedule-reminder branch May 21, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants