Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for type aliases and !@include directives in the IDL, which is a great feature enhancement. The changes are comprehensive, touching the parser, AST, client generator, and templates to accommodate these new features. A new preprocessor is also added to handle the include logic. The implementation is solid, but I've identified a bug in the client code generator that results in a trailing comma in generic type parameter lists. I've also noted a potential robustness issue in the preprocessor's logic for detecting top-level scope, which could be improved for future maintainability. Overall, great work on this feature.
6bbc475 to
1f53307
Compare
77d1f31 to
905e4fa
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces an IDL preprocessor in sails-idl-parser-v2 to support !@include directives, enabling modular IDL definitions and preventing duplicate inclusions through content hashing. The client-gen crate has been updated to utilize this new preprocessor. Feedback suggests refining the brace_level handling in the preprocessor for better syntax error management and improving the test IdlLoader implementation to use content hashing for more robust uniqueness checks and path resolution.
7944995 to
028c856
Compare
3f0b8b6 to
0b72afb
Compare
0b72afb to
f7d4d7f
Compare
No description provided.