Skip to content

fix: use deepClone for Skin._skinMatrices to prevent undefined after clone #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cptbtptpbcptdtptp merged 1 commit into from
Apr 7, 2026
Merged

fix: use deepClone for Skin._skinMatrices to prevent undefined after clone #2941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/mesh/Skin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class Skin extends EngineObject {
inverseBindMatrices = new Array<Matrix>();

/** @internal */
@ignoreClone
@deepClone
Copy link
Copy Markdown

@augmentcode augmentcode bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a small regression test that Skin.clone() produces an independent _skinMatrices (i.e., not the same Float32Array reference), since this change is specifically fixing shared-state cloning bugs.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

_skinMatrices: Float32Array;
/** @internal */
@ignoreClone
Expand Down
Loading