Fix SIGINT not closing Grayjay in headless/server mode#914
Open
VictorVow wants to merge 1 commit intofuto-org:masterfrom
Open
Fix SIGINT not closing Grayjay in headless/server mode#914VictorVow wants to merge 1 commit intofuto-org:masterfrom
VictorVow wants to merge 1 commit intofuto-org:masterfrom
Conversation
Register Console.CancelKeyPress and AppDomain.ProcessExit handlers to cancel the shared CancellationTokenSource on SIGINT/SIGTERM. This unblocks the WaitHandle.WaitOne() call in headless mode (and the WaitForExitAsync call in windowed mode), allowing cleanup to run and the process to exit gracefully. Fixes futo-org#569
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--headlessrunning doesn't close Grayjay #569Console.CancelKeyPresshandler that cancels the sharedCancellationTokenSourceon SIGINT (Ctrl+C), rather than letting the signal propagate unhandledAppDomain.CurrentDomain.ProcessExithandler for the same token to cover SIGTERMWaitHandle.WaitOne()in headless/server mode (andWaitForExitAsyncin windowed mode), allowing the cleanup sequence to run and the process to exit gracefully