スキーマのアップデートに伴う修正#15
Merged
kantacky merged 32 commits intoupdate-openapi-schemafrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
OpenAPIスキーマ更新に追従し、生成コード・BFFハンドラ・モジュール名を更新して、管理BFFのAPI定義/実装を最新化するPRです。
Changes:
- OpenAPIのレスポンス/参照表記を更新し、科目一覧を
SubjectSummaryベースに変更 - Go module を
github.com/fun-dotto/admin-bff-apiに変更し、関連importパスを更新 - 不要になったハンドラ（course 等）を削除し、subjectハンドラを新しい外部クライアント仕様に追従
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| openapi/openapi.yaml | スキーマ参照のクオート統一、Subjects list を SubjectSummary に変更し新schemaを追加 |
| generated/api.gen.go | OpenAPI変更に伴う生成モデル/レスポンス型の更新（Subjects list が Summary 化） |
| go.mod | moduleパスを admin-bff-api に変更 |
| cmd/server/main.go | moduleパス変更に伴うimport更新 |
| internal/infrastructure/clients.go | 生成外部クライアントimportのmoduleパス更新 |
| internal/handler/handler.go | generated/外部クライアントのimport更新 |
| internal/handler/announcement.go | middleware/外部クライアントのimport更新 |
| internal/handler/faculty.go | 外部APIの型変更に追従（DottoFoundationV1FacultyRequest へ）＋import更新 |
| internal/handler/subject.go | Subjects list のparams対応、create/update を upstream upsert 呼び出しへ変更 |
| internal/handler/course.go (deleted) | 不要ファイル削除 |
| internal/handler/day_of_week_timetable_slot.go (deleted) | 不要ファイル削除 |
| internal/handler/subject_category.go (deleted) | 不要ファイル削除 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… of an empty struct
Member
|
@hikaru-0602 |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 17 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 18 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
openapi/openapi.yaml:736
- The path segment
itmeslooks like a typo ofitems(appears in both/v1/timetable/itmesand/v1/timetable/itmes/{id}), and it propagates into the generated router/clients. If this is unintentional, fix the OpenAPI paths to.../items...and regenerate the code; otherwise consider adding a clarifying comment since the misspelling becomes part of the public API surface.
/v1/timetable/itmes/{id}:
delete:
operationId: TimetableItemsV1_delete
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kantacky
added a commit
that referenced
this pull request
Mar 2, 2026
* Update OpenAPI schema from dotto-typespec * SubjectAPIのOpenAPI更新 * task generetaで更新 * task generateで更新 * Update OpenAPI schema from dotto-typespec * Update OpenAPI schema from dotto-typespec * Update OpenAPI schema from dotto-typespec * Update OpenAPI schema from dotto-typespec * Update OpenAPI schema from dotto-typespec * スキーマのアップデートに伴う修正 (#15) * コースを削除 * 時限を削除 * 科目区分を削除 * Facultyを更新 * Subjectを更新 * 名前修正 * スキーマ更新 * task generate * Update internal/handler/subject.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor SubjectsV1List to simplify parameters by passing nil instead of an empty struct * FacultyのURL追加 * TaskfileにFaculty追加 * FacultyのConfig追加 * Facultyのクライアント生成処理追加 * Adminのtask generate * Facultyのtask generate * Subjectのtask generate * Handlerの初期化にFaculty追加 * FacultyのHandler実装 * SubjectのHandler実装 * main修正 * Update internal/handler/subject.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Adminのtask generate * Facultyのtask generate * Subjectのtask geenrate * Announcementのスキーマ変更に伴う修正 * Facultyのスキーマ変更に伴う修正 * Subjectのスキーマ変更に伴う修正 * インターフェース満たすために簡易実装 * クエリを変換する処理 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: kantacky <51151242+kantacky@users.noreply.github.com> Co-authored-by: Hikaru Saito <beretta0602@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hikaru Saito <135803012+hikaru-0602@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kanta Oikawa <iam@kantacky.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと