NaN-handling for ensemble CRPS#118
Open
frazane wants to merge 16 commits into
Open
Conversation
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
sallen12
reviewed
Apr 1, 2026
Owner
Author
|
@sallen12 I reimplemented the NaN-handling like you suggested, using the ensemble weighting functionality and setting NaN members weights (and values) to zero. I only realized this was indeed an option after merging main into this branch. My bad! This is now greatly simplified. There is still a couple of edge cases that need to be handled (AKR estimators). Perhaps we can have a chat about this soon. |
…', 'int' estimators
Owner
Author
|
@nicholasloveday any feedback here would be welcome! |
frazane
commented
May 2, 2026
Owner
Author
There was a problem hiding this comment.
Note: I left the ad-hoc AKR estimators for the 'omit' nan policy, but we are not using them in the high level API. We will decide later. For now, choosing AKR estimators or INT with 'omit' policy will raise a NotImplementedException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces handling of NaN values in ensemble CRPS scoring functions via NaN policy selection. Three policies are supported:
'propagate': if any member of an ensemble is NaN, the function returns NaN'omit': the function will omit NaN values from the computation'raise': the function will raise an error if any NaNs are present in the input arraysThese are now values given to a new
nan_policyparameter forcrps_ensemble,twcrps_ensemble,owcrps_ensemble, andvrcrps_ensemble.