Add Code Link Plugin and CLI #508
Conversation
huntercaron
force-pushed
the
code-link
branch
2 times, most recently
from
82924c4 to
1d341eb
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
huntercaron
force-pushed
the
code-link
branch
from
a174ebb to
6fca218
Compare
|
This PR has been automatically marked as stale because it has not had any activity in the last 7 days. It will be closed if no further activity occurs in the next 7 days. |
triozer
left a comment
triozer
left a comment
There was a problem hiding this comment.
First review pass, looks really good!
huntercaron
force-pushed
the
code-link
branch
from
a82e34b to
5ffe0ac
Compare
| try { | ||
| const shouldDelete = await userActions.requestDeleteDecision(syncState.socket, { | ||
| fileName: effect.fileName, | ||
| requireConfirmation: !config.dangerouslyAutoDelete, |
There was a problem hiding this comment.
Should not this also use effect.requireConfirmation?
There was a problem hiding this comment.
Reworked this to be more clear, it now always accesses the config directly rather than having a parameter on the effect. Also renamed the effects to be more obvious
| const projectShortHash = shortProjectHash(state.project.id) | ||
|
|
||
| log.debug("Opening WebSocket", { port, attempt, project: projectName }) | ||
| const socket = new WebSocket(`ws://localhost:${port}`) |
There was a problem hiding this comment.
Should we use secure web sockets?
There was a problem hiding this comment.
Don't think we would gain much, and we'd have to handle certs. I think fine like this?
- Improve clarity of effect names - Better support deletion of multiple files - Ensure local deletions always require confirmation on resync
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Description
Adds a Code Link Plugin and
framer-code-linkCLI tool for a 2-way link between code files in Framer and local filesystem.Todo
Testing