Skip to content

Remove sphinx-toolbox#899

Merged
kprosise merged 1 commit intofoundriesio:mainfrom
kprosise:remove-toolbox
Mar 16, 2026
Merged

Remove sphinx-toolbox#899
kprosise merged 1 commit intofoundriesio:mainfrom
kprosise:remove-toolbox

Conversation

@kprosise
Copy link
Contributor

Extension was only being used for the confval domain, which has been builtin to Sphinx since sphinx 7.0, rendering the extension redundant. Additionally, the extension holds back the docs from being updated to a newer Sphinx release.

Checked built output, minor differences in rendering, but overall effect remains the same, and no issues spotted.

This commit applies to FFTK-4730, "Update Sphinx and dependencies"

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.
You may delete items that are not relevant to your contribution.
Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck, and add redirects for any moved or deleted pages.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Extension was only being used for the  ``confval`` domain, which has
been builtin to Sphinx since sphinx 7.0, rendering the extension
redundant. Additionally, the extension holds back the docs from being
updated to a newer Sphinx release.

Checked built output, minor differences in rendering, but overall effect
remains the same, and no issues spotted.

This commit applies to FFTK-4730, "Update Sphinx and dependencies"

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise requested review from a team and vanmaegima March 16, 2026 14:08
@kprosise kprosise merged commit ffa54a9 into foundriesio:main Mar 16, 2026
2 of 3 checks passed
@kprosise kprosise deleted the remove-toolbox branch March 16, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants