fix: correct FoD session login credential grouping and tenant option usage#944
Open
SangameshV wants to merge 1 commit intodev/v3.xfrom
Open
fix: correct FoD session login credential grouping and tenant option usage#944SangameshV wants to merge 1 commit intodev/v3.xfrom
SangameshV wants to merge 1 commit intodev/v3.xfrom
Conversation
rsenden
requested changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
This change is not backward-compatible, as pipelines/automations may already be combining --tenant with --client-id & --client-secret; with this change, such pipelines/automations will start failing as this combination is no longer allowed.
We either need to revert to the old behavior, or somehow update the current implementation to also accept --tenant as an optional/ignored option in combination with --client-id and --client-secret, for example utilizing Picocli functionality to pre-process parameters/options and ignoring/removing the --tenant option if --client-id or --client-secret has also been specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--tenantoption was not displayed as mandatory for thefcli fod session logincommand when using theusername/passwordoption group. It is now required whenusernameandpasswordare provided, but not when using theclient-idandclient-tokenoptions.