Added SPDX license codes to all formula files#244
Conversation
8489b76 to
45a8927
Compare
|
@suleman-uzair I've done some investigation and some license codes are incorrect. I've fixed the fonts f1.8 and joongnajoche because they are actually OFL (fixed in v4 already) The available licenses are here: Some of the assignments are more nuanced:
license_url: http://scripts.sil.org/OFL
open_license: |-
Copyright (c) 2010-2013 by tyPoland Lukasz Dziedzic with Reserved Font Name "Carlito".
This Font Software is licensed under the SIL Open Font License,
Version 1.1 as shown below.The SPDX code is There seem to be 3 variants of OFL:
OFL seems to be the only one to be fixed. Then we have the proprietary licenses. According to spdx/license-list-XML#1856 we can encode them like
We just need a code for each of these. |
|
Here's the raw text ready to paste: SPDX License Update SummaryUpdated all 2,163 formula Changes by CategoryOFL Variants (1,698 files)
Apple (319 files)
Microsoft (29 files)
Adobe (2 files)
Other Vendor-Specific (3 files)
Free/Custom Licenses (25 files)
Needs Review
|
|
@suleman-uzair there are a few errors. OFL RFN assignmentMost of the RFN assignments are wrong. Regarding OFL RFN: Just because the license contains "Reserved Font Name" does not mean the license is RFN. For example:
ming_uni
The original license is correct as stated in gwm_sans_*
Incorrect. This is a translated "SIL OFL 1.1 with RFN" with a vendor-specific preface (which is common practice when adopting OFL). So it is just SIL OFL 1.1 with RFN. Additional licenseI also found this: In:
Need a new license for this? Answers to the questions
Yes, 10646 not 10464.
All 6 use the same license. There is a separate license I mentioned above.
We need to represent that a font can have multiple licenses.
Use Relationships between licensesThere are a few notable issues here uncovered:
We need to basically define a schema for a license, and then have a register of these licenses, e.g. fontist/licenses and we can reference them properly. For now, we can just fix the issues and then have the license relationship as a separate enhancement. |
|
@ronaldtse Thanks for the detailed review. All corrections applied:
Please let me know if any further changes are needed. |
|
@suleman-uzair @HassanAkbar please merge when ready. Thanks! Let's make this a feature of Fontist Formula v5. |
|
@HassanAkbar @suleman-uzair Maybe we should merge this into #222 directly? |
@ronaldtse sure, I’ll retarget this PR to the branch used by #222 and merge it there. |
4795280 to
f765770
Compare
Adds a new
spdx_licensefield to all formula files using official SPDX identifiers or LicenseRef- custom encoding for non-standard licenses.closes #240